10.4/releng-p6.diff

Index: UPDATING
===================================================================
--- UPDATING	(revision 326723)
+++ UPDATING	(revision 330566)
@@ -16,6 +16,19 @@
 stable/10, and then rebuild without this option. The bootstrap process from
 older version of current is a bit fragile.
 
+20180307	p6	FreeBSD-SA-18:01.ipsec
+			FreeBSD-SA-18:02.ntp
+			FreeBSD-EN-18:01.tzdata
+			FreeBSD-EN-18:02.file
+
+	Fix ipsec validation and use-after-free. [SA-18:01.ipsec]
+
+	Fix multiple vulnerabilities in ntp. [SA-18:02.ntp]
+
+	Update timezone database information. [EN-18:01.tzdata]
+
+	Update file(1) to new version with security update. [EN-18:02.file]
+
 20171209	p5	FreeBSD-SA-17:12.openssl
 
 	Fix OpenSSL error state vulnerability.
Index: sys/conf/newvers.sh
===================================================================
--- sys/conf/newvers.sh	(revision 326723)
+++ sys/conf/newvers.sh	(revision 330566)
@@ -32,7 +32,7 @@
 
 TYPE="FreeBSD"
 REVISION="10.4"
-BRANCH="RELEASE-p5"
+BRANCH="RELEASE-p6"
 if [ "X${BRANCH_OVERRIDE}" != "X" ]; then
 	BRANCH=${BRANCH_OVERRIDE}
 fi
Index: sys/netipsec/xform_ah.c
===================================================================
--- sys/netipsec/xform_ah.c	(revision 326723)
+++ sys/netipsec/xform_ah.c	(revision 330566)
@@ -615,6 +615,16 @@
 		m_freem(m);
 		return EACCES;
 	}
+	if (skip + authsize + rplen > m->m_pkthdr.len) {
+		DPRINTF(("%s: bad mbuf length %u (expecting %lu)"
+		    " for packet in SA %s/%08lx\n", __func__,
+		    m->m_pkthdr.len, (u_long) (skip + authsize + rplen),
+		    ipsec_address(&sav->sah->saidx.dst, buf, sizeof(buf)),
+		    (u_long) ntohl(sav->spi)));
+		AHSTAT_INC(ahs_badauthl);
+		error = EACCES;
+		goto bad;
+	}
 	AHSTAT_ADD(ahs_ibytes, m->m_pkthdr.len - skip - hl);
 
 	/* Get crypto descriptors. */
@@ -680,6 +690,9 @@
 		/* Zeroize the authenticator on the packet. */
 		m_copyback(m, skip + rplen, authsize, ipseczeroes);
 
+		/* Save ah_nxt, since ah pointer can become invalid after "massage" */
+		hl = ah->ah_nxt;
+
 		/* "Massage" the packet headers for crypto processing. */
 		error = ah_massage_headers(&m, sav->sah->saidx.dst.sa.sa_family,
 		    skip, ahx->type, 0);
@@ -704,7 +717,7 @@
 	tc->tc_spi = sav->spi;
 	tc->tc_dst = sav->sah->saidx.dst;
 	tc->tc_proto = sav->sah->saidx.proto;
-	tc->tc_nxt = ah->ah_nxt;
+	tc->tc_nxt = hl;
 	tc->tc_protoff = protoff;
 	tc->tc_skip = skip;
 	tc->tc_ptr = (caddr_t) mtag; /* Save the mtag we've identified. */