tag ea4a64f8d6375b005cd95c908aecf547b017b965
tagger Luca Boccassi <luca.boccassi@microsoft.com> Tue Jan 18 11:42:09 2022 +0000
object 921810ea23357988ce67f49190f43abef1788a9c

systemd-stable v247.11
-----BEGIN PGP SIGNATURE-----

iQJQBAABCgA6FiEErCSqx93EIPGOymuRKGv37813JB4FAmHmp5EcHGx1Y2EuYm9j
Y2Fzc2lAbWljcm9zb2Z0LmNvbQAKCRAoa/fvzXckHlkhD/40BhjJi9WgxImPPrW+
SqY0Z2G1OHX0TGLqsACyyOPVS157jlWl0CcdFBGnUf+r9jZlk1txxRQ8b7xkheac
82DA+4/whoU9tpW+6WkOtkBAsb7G5AfpLmVSgSw4wlC7G352aXrg4H0MjDqkek3n
UnovdDuMMcvLtnKh6+1864NDRbLd0KPcUmXl/eeuK+e9R1nJ27S2wpFbscGLO8vX
o/MfO54wmKipgZdZJ0AA5huVnj7Hg4ItSWUgVVeIrkILUDwKZn/AkZlGsCETvh1Y
ywls3jTuMdDd8cXI/4iP7DDaiMBVPlsRjdlZFQAauQDo3agKmPXWOZ6xf6hNPbnF
7/cbqqN5kWHPIRBFT0zSslfSw2BG7aA3AwX8CJyPtKa+414EMgDfyVsP6p5kkhm8
xfpeI2o+Tgeos6qrJSwU4hXKX6FFWsfLW3qr2L2MBragw5EKtgHFy/DCn++6SMn/
Tcf0J8INJ0M7wTcMrs5imCrtiDVKHHSXths+48hhmBnmLXl8cx39i9Y/k5pbys1h
lMxhbyv8beRk8UziU9t4rGxwCK+pSOZt3q+ASEX0p4sMFenUPX+Dyd1BJMj/AONe
eYtUc2wz/vSRO8PBNJm8KFKRbvtVnTvkOuyKPVAZcwwn2CdzzI1HOriYgnXW1TbL
onneY7TMjU9eQ+oAQ3jl1GUuUA==
=63zD
-----END PGP SIGNATURE-----

commit 921810ea23357988ce67f49190f43abef1788a9c
author Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> Tue Nov 30 22:29:05 2021 +0100
committer Luca Boccassi <luca.boccassi@gmail.com> Tue Jan 18 11:33:27 2022 +0000
tree 0387bec65b8e6e21bdd18e5e9133e40f4f90048a
parent aaad978868bd6ac84d463a94357ddcbc43b24248

shared/rm-rf: loop over nested directories instead of instead of recursing

To remove directory structures, we need to remove the innermost items first,
and then recursively remove higher-level directories. We would recursively
descend into directories and invoke rm_rf_children and rm_rm_children_inner.
This is problematic when too many directories are nested.

Instead, let's create a "TODO" queue. In the the queue, for each level we
hold the DIR* object we were working on, and the name of the directory. This
allows us to leave a partially-processed directory, and restart the removal
loop one level down. When done with the inner directory, we use the name to
unlinkat() it from the parent, and proceed with the removal of other items.

Because the nesting is increased by one level, it is best to view this patch
with -b/--ignore-space-change.

This fixes CVE-2021-3997, https://bugzilla.redhat.com/show_bug.cgi?id=2024639.
The issue was reported and patches reviewed by Qualys Team.
Mauro Matteo Cascella and Riccardo Schirone from Red Hat handled the disclosure.

(cherry picked from commit 5b1cf7a9be37e20133c0208005274ce4a5b5c6a1)
(cherry picked from commit 911516e1614e435755814ada5fc6064fa107a105)
(cherry picked from commit 6a28f8b55904c818b25e4db2e1511faac79fd471)
(cherry picked from commit c752f27b7647c99b4a17477c99d84fd8c950ddf0)