tag b5ca06f13739f6fae3b73ccfc89d1e4d152329a2
tagger Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> Wed Aug 26 14:37:26 2020 +0200
object b7cef386bd1bc810f5bb12d84c2ec4d6428231e3

systemd-stable v246.3
-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEXCUbX8VOsvgPQHqqxUyjNs/rVX4FAl9GV4YACgkQxUyjNs/r
VX74qg//R1Csv/OSWh0+F4tDu432COzvSn9gCrTXNITillx/IQTbAH9Qufib2eMa
XtWprS8N1GNLHacEVgEHnlTJDSqaW+nbeILKraSEM4k+EGVb1224G2aMf0hz28gc
sm8CQIJCEm5vVW7I6pJj3OfHVvkeeNFKVyhJc4Mt8+f6II7zbYajWUkFpMElf1Pd
GFlU1sSJZsUqvemN2vzMDPjRwlEhx9jApbCTHQ5sVBaQQwTTIquuxsLE3nXrPpDN
lcly2p1u9do75i9CLDF/1uis3c3dmpvTn6rY9yeh0a92H05jx1ZrcCTrrIYM81Mj
IdHLHLVnPkPkdeEnT6JBbijy+7ufewZ0tcxz9whD5Q/9zddzClaT+osSLYkj2lgD
poQlAwO1EcMNZJkU/KAfvuNj9CYff40RElGC+qlzlzCk/C60ihkWt696easkd8V+
LvuxJANiko+7lmz6jJlywrzYhV7/EzX8xRT4mfkaBIoG7jSU5a+5mYhFHhgnEwBO
84j5nAAtNZh0/MvjCexfQuqrQT1lEScP6P5HLqR4r/ZPjtn2DKHg3Dl/+gAQ81u5
rPvN7HmkLyrfgP2P9n+X9B+1NXrFdyjjsyjhqQp/gv7mTroSP5odtM/mif5bVdaz
cEN0VFbt2dROZfI2Z5glm/EtTrxZRTa/hJRAGYkaPDP10cnixAk=
=JouJ
-----END PGP SIGNATURE-----

commit b7cef386bd1bc810f5bb12d84c2ec4d6428231e3
author Chris Down <chris@chrisdown.name> Tue Aug 25 21:59:11 2020 +0100
committer Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> Wed Aug 26 14:35:32 2020 +0200
tree 631c80a63144b59a9ed5dff80dddfbd9c75cd55e
parent 122945f315c8ccb1ecaf8384aff85931791d45d3

path: Skip directories when finalising $PATH search

Imagine $PATH /a:/b. There is an echo command at /b/echo. Under this
configuration, this works fine:

    % systemd-run --user --scope echo .
    Running scope as unit: run-rfe98e0574b424d63a641644af511ff30.scope
    .

However, if I do `mkdir /a/echo`, this happens:

    % systemd-run --user --scope echo .
    Running scope as unit: run-rcbe9369537ed47f282ee12ce9f692046.scope
    Failed to execute: Permission denied

We check whether the resulting file is executable for the performing
user, but of course, most directories are anyway, since that's needed to
list within it. As such, another is_dir() check is needed prior to
considering the search result final.

Another approach might be to check S_ISREG, but there may be more gnarly
edge cases there than just eliminating this obviously pathological
example, so let's just do this for now.

(cherry picked from commit 8b5cb69bc8b70d1dcc39ed2165907723099bd9d8)