| commit | dc81e5e35ff7cdb255d164f707f39568818c4c20 | [log] [download] |
|---|---|---|
| author | Dave Borowitz <dborowitz@google.com> | Wed Jul 27 18:11:12 2016 -0400 |
| committer | Dave Borowitz <dborowitz@google.com> | Wed Jul 27 18:11:12 2016 -0400 |
| tree | ad1283095662ea0edf20f2736fa98c350af40e91 | |
| parent | c77a18bb159c2e0e0b5f973f275ac442927696d1 [diff] |
BlobSoyData: Remove special handling of \r The only benefit of handling \r\n specially is to avoid emitting "<td>foo\r</td>" for lines ending in \r\n. In practice, browsers don't render the \r, so this is basically a non-issue. The major downside of handling \r\n specially is that it disagrees with the internals of JGit, which always assumes \n line endings. There was a bug in the existing code that treated bare \r not followed by \n as a newline, which broke the code in BlameServlet that assumes the number of lines in the blame (from JGit internals) is the same as in the BlobSoyData. Rather than fixing that bug by introducing more complexity, we decided to go with the safest option, which is to match JGit internals. Change-Id: I4c96c3dc21260c13c311a6c018302d759c5b6e17
Gitiles is a simple repository browser for Git repositories, built on JGit. Its guiding principle is simplicity: it has no formal access controls, no write access, no fancy Javascript, etc.
Gitiles requires Buck to build.
sudo apt-get install ant
cd ${HOME}
git clone https://github.com/facebook/buck.git
cd buck
ant
sudo ln -s ${PWD}/bin/buck /usr/bin/buck
cd /path/to/gitiles
git submodule update --init
buck build all
buck test
cd /path/to/repositories # Don't run from the gitiles repo. /path/to/gitiles/tools/run_dev.sh
This will recompile and start a development server. Open http://localhost:8080/ to view your local copy of gitiles, which will serve any repositories under /path/to/repositories.
To run unit tests, run buck test.
If you'd like to use Eclipse to edit Gitiles, first generate a project file:
./bucklets/tools/eclipse.py --src
Import the project in Eclipse:
File -> Import -> Existing Projects into Workpace
The project only needs to be rebuilt if the source roots or third-party libraries have changed. For best results, ensure the project is closed in Eclipse before rebuilding.
Java code in Gitiles follows the Google Java Style Guide with a 100-column limit.
Code should be automatically formatted using google-java-format prior to sending a code review. There is currently no Eclipse formatter, but the tool can be run from the command line:
java -jar /path/to/google-java-format-1.0-all-deps.jar -i path/to/java/File.java
CSS in Gitiles follows the SUIT CSS naming conventions.
Gitiles uses Gerrit for code review: https://gerrit-review.googlesource.com/
Gitiles uses the “git push” workflow with server https://gerrit.googlesource.com/gitiles. You will need a generated cookie.
Gerrit depends on “Change-Id” annotations in your commit message. If you try to push a commit without one, it will explain how to install the proper git-hook:
curl -Lo `git rev-parse --git-dir`/hooks/commit-msg \
https://gerrit-review.googlesource.com/tools/hooks/commit-msg
chmod +x `git rev-parse --git-dir`/hooks/commit-msg
Before you create your local commit (which you'll push to Gerrit) you will need to set your email to match your Gerrit account:
git config --local --add user.email foo@bar.com
Normally you will create code reviews by pushing for master:
git push origin HEAD:refs/for/master