commit | 3b744b1012f1c2d645fd297f00e9ec2e71c5f197 | [log] [download] |
---|---|---|
author | Dave Borowitz <dborowitz@google.com> | Fri Aug 19 16:11:10 2016 -0400 |
committer | Dave Borowitz <dborowitz@google.com> | Fri Aug 19 16:17:02 2016 -0400 |
tree | d2e1ca288571a6d8f117455d0eae8527e8a857ea | |
parent | 27fedf439fe50f5d4ebfeb7503335db1663edcf9 [diff] |
Remove complex import order Google's style guide changed its complex rules to be much simpler: all static imports, then all non-static imports: https://google.github.io/styleguide/javaguide.html#s3.3.3-import-ordering-and-spacing google-java-format will also understand this order. Change the Eclipse project settings and .importorder file, and reorder everything. Change-Id: I0bd3a085ef00ceee88d06e2c4b4711f1f696e4ae
Gitiles is a simple repository browser for Git repositories, built on JGit. Its guiding principle is simplicity: it has no formal access controls, no write access, no fancy Javascript, etc.
Gitiles requires Buck to build.
sudo apt-get install ant cd ${HOME} git clone https://github.com/facebook/buck.git cd buck ant sudo ln -s ${PWD}/bin/buck /usr/bin/buck cd /path/to/gitiles git submodule update --init buck build all buck test
cd /path/to/repositories # Don't run from the gitiles repo. /path/to/gitiles/tools/run_dev.sh
This will recompile and start a development server. Open http://localhost:8080/ to view your local copy of gitiles, which will serve any repositories under /path/to/repositories
.
To run unit tests, run buck test
.
If you'd like to use Eclipse to edit Gitiles, first generate a project file:
./bucklets/tools/eclipse.py --src
Import the project in Eclipse:
File -> Import -> Existing Projects into Workpace
The project only needs to be rebuilt if the source roots or third-party libraries have changed. For best results, ensure the project is closed in Eclipse before rebuilding.
Java code in Gitiles follows the Google Java Style Guide with a 100-column limit.
Code should be automatically formatted using google-java-format prior to sending a code review. There is currently no Eclipse formatter, but the tool can be run from the command line:
java -jar /path/to/google-java-format-1.0-all-deps.jar -i path/to/java/File.java
CSS in Gitiles follows the SUIT CSS naming conventions.
Gitiles uses Gerrit for code review: https://gerrit-review.googlesource.com/
Gitiles uses the “git push” workflow with server https://gerrit.googlesource.com/gitiles. You will need a generated cookie.
Gerrit depends on “Change-Id” annotations in your commit message. If you try to push a commit without one, it will explain how to install the proper git-hook:
curl -Lo `git rev-parse --git-dir`/hooks/commit-msg \ https://gerrit-review.googlesource.com/tools/hooks/commit-msg chmod +x `git rev-parse --git-dir`/hooks/commit-msg
Before you create your local commit (which you'll push to Gerrit) you will need to set your email to match your Gerrit account:
git config --local --add user.email foo@bar.com
Normally you will create code reviews by pushing for master:
git push origin HEAD:refs/for/master